[Routing] marked configurators traits as internal #35731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HeahDude
commented
Feb 15, 2020
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #30501 (comment) |
| License | MIT |
| Doc PR | not needed |
Merged
4 tasks
src/Symfony/Component/Routing/Loader/Configurator/Traits/AddTrait.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Routing/Loader/Configurator/Traits/RouteTrait.php
Outdated
Show resolved
Hide resolved
|
Only traits new to 5.1 should be made internal. |
811cb81 to
52efec7
Compare
|
Alright, fixed. |
nicolas-grekas
approved these changes
Feb 15, 2020
|
Thank you @HeahDude. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 15, 2020
…ude) This PR was merged into the 5.1-dev branch. Discussion ---------- [Routing] marked configurators traits as internal | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #30501 (comment) <!-- prefix each issue number with "Fix #", if any --> | License | MIT | Doc PR | not needed <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - Never break backward compatibility (see https://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch master. --> Commits ------- 52efec7 [Routing] marked configurators traits as internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.