[Security] Deprecated ROLE_PREVIOUS_ADMIN #35858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7a77762 to
d0bf1c1
Compare
d0bf1c1 to
dce55f3
Compare
fabpot
approved these changes
Feb 25, 2020
|
Thank you @wouterj. |
fabpot
added a commit
that referenced
this pull request
Feb 29, 2020
…wouterj) This PR was merged into the 5.1-dev branch. Discussion ---------- Added ROLE_PREVIOUS_ADMIN deprecation to UPGRADE guide | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | n/a I forgot to update the UPGRADE guides in #35858 Commits ------- 3c8d316 Added ROLE_PREVIOUS_ADMIN deprecation to UPGRADE guide
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ROLE_PREVIOUS_ADMINis added to the token roles if the session is an impersonation. Since #31189 we have theIS_IMPERSONATORattribute which can be used for the same reason. I propose to deprecate theROLE_PREVIOUS_ADMIN:AbstractToken)ROLE_PREVIOUS_ADMINwithIS_IMPERSONATOR:find ./ -type f -exec sed -i 's/ROLE_PREVIOUS_ADMIN/IS_IMPERSONATOR/g' {} +I'm a bit unsure on how to deprecate this role, but I think having it in
RoleVoteris probably the safest (isGranted()and variants +AccessDecisionManager#decide()all use this voter to check if the token has this role).