Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DomCrawler] prevent deprecation being triggered from assertion #35899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2020
Merged

[DomCrawler] prevent deprecation being triggered from assertion #35899

merged 1 commit into from
Mar 2, 2020

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Feb 28, 2020

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #35889
License MIT
Doc PR

@xabbuh xabbuh added this to the 4.4 milestone Feb 28, 2020
@xabbuh xabbuh mentioned this pull request Feb 28, 2020
Closed
fancyweb
fancyweb approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@fancyweb fancyweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As pointed in the issue, don't we need to also update https://github.com/symfony/dom-crawler/blob/4.4/Test/Constraint/CrawlerSelectorTextSame.php#L48?

@xabbuh
Copy link
Member Author

xabbuh commented Mar 1, 2020

@fancyweb Indeed, I fixed it.

@fabpot
Copy link
Member

fabpot commented Mar 2, 2020

Thank you @xabbuh.

@fabpot fabpot merged commit 0936a4e into symfony:4.4 Mar 2, 2020
@xabbuh xabbuh deleted the issue-35889 branch March 2, 2020 12:27
This was referenced Mar 27, 2020
Merged
Merged
@dunglas dunglas mentioned this pull request Mar 29, 2020
Merged
nicolas-grekas added a commit that referenced this pull request Mar 30, 2020
@nicolas-grekas
bug #36259 [DomCrawler] Fix BC break in assertions breaking Panther (…
ff2c362 
…dunglas)

This PR was merged into the 4.4 branch.

Discussion
----------

[DomCrawler] Fix BC break in assertions breaking Panther

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | n/a
| License       | MIT
| Doc PR        | n/a

#35899 introduces a BC break: browsers aren't able to retrieve the non-normalized version of a text. According to the HTML spec, whitespaces are always normalized. Because of this patch, these assertions doesn't work with Panther anymore.

Also, this change probably hurts other users because getting the non-normalized version is almost never expected. (I'm in favor of **not** supporting retrieving the non-normalized version at all, for consistency with browsers and the spec, but it's another topic).

Commits
-------

7af07c8 [DomCrawler] Fix BC break in assertions breaking Panther
@iceuponfire iceuponfire mentioned this pull request Mar 30, 2020
Closed
@flaushi
Copy link

flaushi commented Apr 2, 2020

Maybe we could add a hint to assertSelectorTextSame into the error message

symfony/src/Symfony/Component/DomCrawler/Crawler.php

Line 619 in 15edfd3

@trigger_error(sprintf('"%s()" will normalize whitespaces by default in Symfony 5.0, set the second "$normalizeWhitespace" argument to false to retrieve the non-normalized version of the text.', __METHOD__), E_USER_DEPRECATED);
? I think many people had to research this issue

@xabbuh
Copy link
Member Author

xabbuh commented Apr 2, 2020

What issue would that solve?

@flaushi
Copy link

flaushi commented Apr 2, 2020

I can imagine may people using $crawler->text() in their tests.

They all have to read through this issue and PR to finally see that there is a new assertion assertSelectorTextSame they can use to prevent the deprecation error. Kind of "documentation in issue"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@fancyweb fancyweb fancyweb approved these changes

Assignees
No one assigned
Labels
Bug DomCrawler Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@xabbuh @fabpot @flaushi @fancyweb @carsonbot