Remove int return type from FlattenException::getCode #35993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobion
suggested changes
Mar 7, 2020
fabpot
approved these changes
Mar 9, 2020
|
Thank you @wucdbm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heya,
So my project died with
Return value of Symfony\Component\ErrorHandler\Exception\FlattenException::getCode() must be of the type int, string returnedsymfony error page. Quite unexpected.Turns out it's a
Doctrine\DBAL\Driver\PDOExceptionwith code42S02and messageSQLSTATE[42S02]: Base table or view not found: 1146 Table 'some_db.some_table' doesn't exist.This is because I use the
FlattenExceptionclass to serialize errors and store elsewhere, just more convenient to quickly check for any errors. I guess noone has stumbled upon a PDOException /FlattenException::getCodebefore.https://www.php.net/manual/en/throwable.getcode.php
Returns the exception code as integer in Exception but possibly as other type in Exception descendants (for example as string in PDOException).