Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixed profiler report under an exception of a sub-request #3618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixed profiler report under an exception of a sub-request #3618

wants to merge 1 commit into from

Conversation

guilhermeblanco
Copy link
Contributor

When a sub-request contains an exception, PdoProfilerStorage was entering in an infinite loop.
Fixed by preventing the read/createProfileFromData recursion.

I experienced this situation when I was trying to consume an undefined variable in a twig template which was part of a sub-request (ESI template).

Associated issue: #3620

This is a PR against 2.0 branch from original PR 3609 #3609

@stof
Copy link
Member

stof commented Apr 3, 2012

@fabpot ping

@guilhermeblanco
Copy link
Contributor Author

@fabpot any input on this one?

I'm pretty much being affected by the lack of this patch. Every request that makes a sub-request and this second request contains an exception, I experience this issue.

fabpot added a commit that referenced this pull request Apr 13, 2012
Commits
-------

01fcb08 [HttpKernel] Fix the ProfilerListener (fix #3620)

Discussion
----------

[HttpKernel] Fix the ProfilerListener (fix #3620)

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: [![Build Status](https://secure.travis-ci.org/vicb/symfony.png?branch=profiler/listener_2.0)](http://travis-ci.org/vicb/symfony)
Fixes the following tickets: #3620, PR #3618

Many thanks to @guilhermeblanco for helping with the tests.

---------------------------------------------------------------------------

by vicb at 2012-04-13T20:10:15Z

For ref: that's basically a backport of #3920 for 2.0
@fabpot fabpot closed this Apr 13, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants