Fixed profiler report under an exception of a sub-request #3618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabpot ping |
|
@fabpot any input on this one? I'm pretty much being affected by the lack of this patch. Every request that makes a sub-request and this second request contains an exception, I experience this issue. |
This was referenced Apr 13, 2012
fabpot
added a commit
that referenced
this pull request
Apr 13, 2012
Commits ------- 01fcb08 [HttpKernel] Fix the ProfilerListener (fix #3620) Discussion ---------- [HttpKernel] Fix the ProfilerListener (fix #3620) Bug fix: yes Feature addition: no Backwards compatibility break: no Symfony2 tests pass: [](http://travis-ci.org/vicb/symfony) Fixes the following tickets: #3620, PR #3618 Many thanks to @guilhermeblanco for helping with the tests. --------------------------------------------------------------------------- by vicb at 2012-04-13T20:10:15Z For ref: that's basically a backport of #3920 for 2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a sub-request contains an exception, PdoProfilerStorage was entering in an infinite loop.
Fixed by preventing the read/createProfileFromData recursion.
I experienced this situation when I was trying to consume an undefined variable in a twig template which was part of a sub-request (ESI template).
Associated issue: #3620
This is a PR against 2.0 branch from original PR 3609 #3609