[DI] dump factory files as classes #36193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
97d12a9 to
eb54c88
Compare
c14f919 to
5f6bff5
Compare
5f6bff5 to
cedb5cd
Compare
Tobion
reviewed
Apr 6, 2020
| @@ -142,6 +142,10 @@ public function registerContainerConfiguration(LoaderInterface $loader) | |||
| } | |||
|
|
|||
| $container->setAlias(static::class, 'kernel')->setPublic(true); | |||
|
|
|||
| if (!$container->hasParameter('container.dumper.inline_factories')) { | |||
| $container->setParameter('container.dumper.inline_factories', false); | |||
There was a problem hiding this comment.
wouldn't it be better to default container.dumper.inline_factories to false when the parameter is not given? you changed this to true in https://github.com/symfony/symfony/pull/34872/files#diff-f7b23d463cba27ac5e4cb677f2be7623R154. so just reverting this would make the default behavior as wanted or?
fabpot
added a commit
that referenced
this pull request
Apr 6, 2020
…ault (nicolas-grekas) This PR was merged into the 5.1-dev branch. Discussion ---------- Revert to container.dumper.inline_factories=false by default | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - As spotted by @Tobion in #36193 (review) Commits ------- 2b6f1e9 Revert to container.dumper.inline_factories=false by default
fabpot
added a commit
that referenced
this pull request
Jun 28, 2020
…rvices (nicolas-grekas) This PR was merged into the 5.1 branch. Discussion ---------- [DI] fix minor perf regression when creating non-shared services | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #37401 | License | MIT | Doc PR | - This PR restores some dumped code that was too aggressively removed in #36193. Commits ------- 75e2ee1 [DI] fix minor perf regression when creating non-shared services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a performance improvement when using
bin/consoleon the command line.Once upon a time, we advised setting
container.dumper.inline_factoriestofalseso that the container could be chunked into many files. More recently, we turned this setting back totruein order to optimize for preloading. But this madebin/consoleback to slow: since the CLI cannot have opcache, PHP has to parse this potentially big file all the time. Previous data already showed this can grow big.This PR fixes the issue by generating many files again. But instead of generating the inline code within each file, we now wrap this code inside a class. Then we list this class for preloading.
This way, we have the best of both worlds: a
bin/consolethat scales no matter the size of the app and top perf when using preloading (I benched a small hello world before/after the patch with preloading enabled, there is no measurable difference.)This should also fix a memory leak that happens when factory files contain closures.