Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Validator] Fixed calling getters before resolving groups #36245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2020
Merged

[Validator] Fixed calling getters before resolving groups #36245

merged 1 commit into from
Mar 31, 2020

Conversation

HeahDude
Copy link
Contributor

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #9939
License MIT
Doc PR ~

@HeahDude HeahDude force-pushed the validator-fix-getters-in-sequence branch from 675b779 to 5741d3e Compare March 27, 2020 19:43
@HeahDude HeahDude mentioned this pull request Mar 27, 2020
Closed
@xabbuh xabbuh added this to the 3.4 milestone Mar 28, 2020
@HeahDude HeahDude force-pushed the validator-fix-getters-in-sequence branch 2 times, most recently from 6c68c39 to 4c91f52 Compare March 28, 2020 10:46
@HeahDude HeahDude force-pushed the validator-fix-getters-in-sequence branch from 4c91f52 to e802cf8 Compare March 28, 2020 11:19
@HeahDude HeahDude force-pushed the validator-fix-getters-in-sequence branch from e802cf8 to edcfd60 Compare March 28, 2020 11:31
@nicolas-grekas
Copy link
Member

Thank you @HeahDude.

@nicolas-grekas nicolas-grekas merged commit b9c2693 into symfony:3.4 Mar 31, 2020
@HeahDude HeahDude deleted the validator-fix-getters-in-sequence branch March 31, 2020 18:50
@HeahDude HeahDude mentioned this pull request Apr 4, 2020
Merged
nicolas-grekas added a commit that referenced this pull request Apr 18, 2020
@nicolas-grekas
bug #36343 [Form] Fixed handling groups sequence validation (HeahDude)
0f1a5c4 
This PR was merged into the 3.4 branch.

Discussion
----------

[Form] Fixed handling groups sequence validation

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | FIx #9939 (comment), Fix #35556
| License       | MIT
| Doc PR        | ~

This is not the same as the original issue fixed by #36245, that was reported in #9939 (comment).

The form also fails to cascade sequence validation properly because each nested field is validated against the sequence, and one can fail at a step independently from another which could failed in another step. I've added a lot of tests to ensure this is working properly and tested in a website skeleton too.

This PR aims to close #35556 which tries to fix the same issue but afterwards in its implementation as said in #35556 (comment).

Commits
-------

dfb61c2 [Form] Fixed handling groups sequence validation
This was referenced Apr 28, 2020
Merged
Merged
Merged
@bendavies
Copy link
Contributor

bendavies commented Apr 29, 2020 •
edited
Loading

this is buggy. it breaks traversal of getters returning collections annotated with Valid constraints.
I will PR if someone doesn't first.

@guilliamxavier guilliamxavier mentioned this pull request Jun 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed Validator
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
6 participants
@HeahDude @nicolas-grekas @bendavies @xabbuh @chalasr @carsonbot