[HttpKernel] Avoid unsuppressed include #36473
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the bug by introducing
includeSafe
, which incorporates the trick about suppressing include-warning.It has several benefits:
file_exists
as it is proven to be performance-killer: Huge performance degradation of ReflectionClassResource and FileResource on big projects inside Docker For Mac #25999 (comment).include
work the same: it increases predictability.