Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Translation] Fix for translation:update command updating ICU messages #36505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2020
Merged

[Translation] Fix for translation:update command updating ICU messages #36505

merged 1 commit into from
May 3, 2020

Conversation

artemoliynyk
Copy link
Contributor

@artemoliynyk artemoliynyk commented Apr 20, 2020 •
edited by nicolas-grekas
Loading

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #36459
License MIT

If translation:update command executed with option --domain=messages – it  ignore messages-intl-icu file and just create new messages

Method TranslationUpdateCommand::filterCatalogue() on MessageCatalogue::all() method to get all messages for domain
But MessageCatalogue::all() method disredard intl-icu domains and simply merge all.

[Translation] added $strict parameter for MessageCatalogueInterface::all() to be able to get only defined domain messages
[FrameworkBundle] modified translation:update command to respect intl-icu domain

@artemoliynyk artemoliynyk mentioned this pull request Apr 20, 2020
Closed
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Apr 21, 2020
@artemoliynyk artemoliynyk marked this pull request as draft April 22, 2020 10:06
@artemoliynyk artemoliynyk marked this pull request as ready for review April 22, 2020 10:38
@artemoliynyk
Copy link
Contributor Author

Travis build fails on Symfony\Bundle\FrameworkBundle\Tests\Functional\MailerTest::testMailerAssertions() test, but it's OK for me on local setup.
I believe this is unrelated erro to this PR

nicolas-grekas
nicolas-grekas reviewed Apr 26, 2020
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, here are some remaining minor comments.

@nicolas-grekas nicolas-grekas changed the base branch from 5.0 to 4.4 April 30, 2020 18:05
@nicolas-grekas nicolas-grekas force-pushed the bug_36459-translation-update-ignore-inlt-icu branch from 284ea74 to 567cee5 Compare April 30, 2020 18:05
yceruto
yceruto approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@yceruto yceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@fabpot
Copy link
Member

fabpot commented May 3, 2020

Thank you @artemoliynyk.

@fabpot fabpot merged commit a5ae434 into symfony:4.4 May 3, 2020
This was referenced May 31, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@yceruto yceruto yceruto approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed Translation
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@artemoliynyk @fabpot @nicolas-grekas @yceruto @carsonbot