Revert "feature #30501 [FrameworkBundle][Routing] added Configurators to handle template and redirect controllers (HeahDude)" #36562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Apr 24, 2020
6f7382f to
e4e8945
Compare
|
Thank you @nicolas-grekas. |
nicolas-grekas
commented
Apr 24, 2020
| @@ -83,7 +83,6 @@ | |||
| "symfony/messenger": "<4.4", | |||
| "symfony/mime": "<4.4", | |||
| "symfony/property-info": "<4.4", | |||
| "symfony/routing": "<5.1", | |||
There was a problem hiding this comment.
should not be re-reverted in the follow-up PR for 5.2
| * @param \DOMElement $node Element to parse that represents a Route | ||
| * @param string $filepath Full path of the XML file being processed | ||
| * @param \DOMElement $node Element to parse that represents a Route | ||
| * @param string $path Full path of the XML file being processed |
There was a problem hiding this comment.
should not be re-reverted in the follow-up PR for 5.2 (same for all this file: the changes put some lines back in their previous state and are fine as is, to reduce the diff between branches)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 477ee19, reversing changes made to 9bfa258.
The reverted PR is #30501. Actually, it's a partial revert: changes made to the
Routingcomponent are not reverted.The reason for this revert is that a discussion is still on-going in #35653 (which provides the same configuration extensions to yaml+xml), and we won't be able to resolve them in time for 5.1.
Better postpone for 5.2.
@HeahDude I invite you to open a PR after this one, reverting this very PR, which we'll consider again but for 5.2 if you don't mind.