Configure services additionally required by the master branch #36704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e9d628c to
f0472a7
Compare
b547ace to
2aca92b
Compare
bendavies
reviewed
May 5, 2020
|
I fixed Travis on master/5.0 and created a small conflict with your PR. Can you please rebase? |
|
Removing the 2nd commit is enough. |
2aca92b to
dc7ac57
Compare
|
Removed the second commit and rebased 👍 |
|
Thank you @jakzal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally run tests for:
Before: Tests: 1893, Assertions: 5178, Skipped: 105.
After: Tests: 2042, Assertions: 5407, Skipped: 120.