Bump Doctrine DBAL to 2.10+ #36790
Merged
Bump Doctrine DBAL to 2.10+ #36790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c79c8be to
27bbdcb
Compare
Tobion
suggested changes
May 12, 2020
src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/Connection.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/Connection.php
Outdated
Show resolved
Hide resolved
Tobion
approved these changes
May 13, 2020
Tobion
reviewed
May 13, 2020
src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/Connection.php
Outdated
Show resolved
Hide resolved
javiereguiluz
added a commit
to EasyCorp/EasyAdminBundle
that referenced
this pull request
May 16, 2020
This PR was merged into the 3.0.x-dev branch. Discussion ---------- Require Doctrine DBAL 2.10 Inspired by symfony/symfony#36790. I think this doesn't introduced any issue in this bundle and we can get rid of some deprecations. Commits ------- 43a1fcc Require Doctrine DBAL 2.10
fabpot
added a commit
that referenced
this pull request
Aug 13, 2020
…alling symfony/messenger (ogizanagi) This PR was merged into the 5.2-dev branch. Discussion ---------- [Messenger] Don't require doctrine/persistence when installing symfony/messenger | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #36790 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | N/A As of today, [installing `symfony/messenger` installs `symfony/doctrine-messenger`](https://github.com/symfony/symfony/blob/3867fb2489ef0d07dec4859cf461bb7bcc7618e0/src/Symfony/Component/Messenger/composer.json#L23) as well. Which means adding `doctrine/persistence` as a hard dep of the latest will install it for any user requiring `symfony/messenger` in 5.2. I think it should stay a soft-dependency until we remove `symfony/doctrine-messenger` as a `symfony/messenger` dependency as of Symfony 6.0 (as mentioned in #35422). --- related: #36785 Commits ------- 5c05455 [Messenger] Don't require doctrine/persistence when installing symfony/messenger
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump Doctrine DBAL to 2.10 and remove obsolete code.