Secrets, Security, and Messenger commands descriptions should not end with a "." (dot) #36798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
May 12, 2020
fabpot
approved these changes
May 12, 2020
… with a "." (dot)
|
Good catch, thanks @carlosbuenosvinos. |
|
Should we add something to the Coding Standards or documentation about writing commands? As a recommendation? |
weaverryan
added a commit
to symfony/maker-bundle
that referenced
this pull request
Aug 25, 2020
…nosvinos) This PR was squashed before being merged into the 1.0-dev branch. Discussion ---------- Remove trailing "." for consistency with #36798 | Q | A | ------------- | --- | Branch? | 5.1 (to be switched while merging) | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A Following symfony/symfony#36798. When running `bin/console` almost all the command descriptions do not end with a ".". So in order to be consistent, we should remove it from the Make Bundle Commands.  Thanks in again for your great work! Commits ------- 8e9a5b7 Remove trailing "." for consistency with #36798
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
bin/consolealmost all the command descriptions do not end with a ".". So in order to be consistent, we should remove it from the Secrets Commands.Current Output for Secrets Commands (with dots)
Other Command Descriptions (without dots)
Symfony CLI output (without dots)
