Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Messenger] Add suggestion for Amazon SQS transport and make check more readable #36890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

RocKordier
Copy link
Contributor

@RocKordier RocKordier commented May 21, 2020

Q A
Branch? 5.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets no
License MIT
Doc PR no
  • Add suggestion for Amazon Simple Queue Service Transport introduced in [Messenger] Add SQS transport #32454
  • make check more readable. Same check is used in all ..Factory->supports(.. functions also and no one has to count characters.

@RocKordier RocKordier requested a review from sroze as a code owner May 21, 2020 10:22
@nicolas-grekas nicolas-grekas changed the title [Messenger] Add suggestion for Amazon SQS transport and make check mo… [Messenger] Add suggestion for Amazon SQS transport and make check more readable May 22, 2020
@nicolas-grekas nicolas-grekas added this to the 5.1 milestone May 22, 2020
@nicolas-grekas nicolas-grekas changed the base branch from master to 5.1 May 22, 2020 08:14
@nicolas-grekas nicolas-grekas changed the base branch from 5.1 to master May 22, 2020 08:14
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(for 5.1)

@chalasr chalasr closed this May 22, 2020
@chalasr chalasr force-pushed the feature/improve-transport-suggestion branch from fcfd60e to 4f93cc1 Compare May 22, 2020 13:40
chalasr added a commit that referenced this pull request May 22, 2020
…make check more readable (RocKordier)

This PR was merged into the 5.1 branch.

Discussion
----------

[Messenger] Add suggestion for Amazon SQS transport and make check more readable

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Copy-paste of #36890

Commits
-------

de7f3fc [Messenger] Add suggestion for Amazon SQS transport and make check more readable
@chalasr
Copy link
Member

chalasr commented May 22, 2020

I missed up with git while merging, sorry.
Merged in #36903. Thank you @RocKordier!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants