Add getFlashBag to SessionInterface #37106
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BackEndTea
commented
Jun 4, 2020
| use Symfony\Component\HttpFoundation\Session\Storage\MetadataBag; | ||
|
|
||
| /** | ||
| * Interface for the session. | ||
| * | ||
| * @author Drak <[email protected]> | ||
| * | ||
| * @method FlashBagInterface getFlashBag() Gets the flashbag interface. - not implementing it is deprecated since Symfony 5.2 |
There was a problem hiding this comment.
Is there a way to validate this, and add a trigger_error?
|
This has been discussed many many times and you will find many PRs about this topics. This has always been rejected (for reasons explained in these closed PRs). Let's close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in issue #36273, the
SessionInterfacedoes not implement this method, but users are expected to hint agains it when injection theSession. Since 5.1 the expected method of getting the flashbag is to inject theSessioninstead, and get the flashbag from that.This change should make it possible to inject the interface, but still be sure that the
getFlashBagmethod is available.