Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MimeType] Duplicated MimeType due to PHP Bug #37291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2020
Merged

[MimeType] Duplicated MimeType due to PHP Bug #37291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[MimeType] Duplicated MimeType due to PHP Bug
  • Loading branch information
@juanmrad @nicolas-grekas
juanmrad authored and nicolas-grekas committed Jun 28, 2020
commit 7cb29c8b4b2990a2555d739ec11d7b9d0d46aff8
8 changes: 7 additions & 1 deletion src/Symfony/Component/HttpFoundation/File/MimeType/FileinfoMimeTypeGuesser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,13 @@ public function guess($path)
if (!$finfo = new \finfo(FILEINFO_MIME_TYPE, $this->magicFile)) {
return null;
}
$mimeType = $finfo->file($path);

return $finfo->file($path);
if ($mimeType && 0 === (\strlen($mimeType) % 2)) {
$mimeStart = substr($mimeType, 0, \strlen($mimeType) >> 1);
$mimeType = $mimeStart.$mimeStart === $mimeType ? $mimeStart : $mimeType;
}

return $mimeType;
}
}
Binary file added src/Symfony/Component/HttpFoundation/Tests/File/Fixtures/test.docx
View file
Open in desktop
Binary file not shown.
8 changes: 8 additions & 0 deletions src/Symfony/Component/HttpFoundation/Tests/File/MimeType/MimeTypeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,14 @@ public function testGuessFileWithUnknownExtension()
$this->assertEquals('application/octet-stream', MimeTypeGuesser::getInstance()->guess(__DIR__.'/../Fixtures/.unknownextension'));
}

/**
* @requires PHP 7.0
*/
public function testGuessWithDuplicatedFileType()
{
$this->assertEquals('application/vnd.openxmlformats-officedocument.wordprocessingml.document', MimeTypeGuesser::getInstance()->guess(__DIR__.'/../Fixtures/test.docx'));
}

public function testGuessWithIncorrectPath()
{
$this->expectException('Symfony\Component\HttpFoundation\File\Exception\FileNotFoundException');
Expand Down