[Mailer] Pass cloned message and envelope to MessageBus #37324
Conversation
|
This change is the same as reverting my original commit, which would revert the fix. Closing. |
|
@fabpot, thank you for your feedback. I agree it will revert your original commit, but I think that commit introduced the actual issue. The original message gets cloned before passing it to the Why should the MessageBus receive the original message and not the cloned "enriched" one? Thanks for trying to help me understand! |
|
The idea is that you always get the event just before sending the email and another one with the queued argument set to true when pushing to the queue. That allows to gather data for tests and the web profiler. Regarding "enriching", it should be done just before the email is triggered regardless of the fact that the queue is used or not. The added benefit is that we serialize a data object, which is very lightweight (see the PR tests for an example). |
…pot) This PR was merged into the 5.2-dev branch. Discussion ---------- [Serializer][Mime] Fix Mime message serialization | Q | A | ------------- | --- | Branch? | master <!-- see below --> | Bug fix? | yes | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #37414, Fix #37324 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | n/a Symfony serialization is used by Messenger to serialize Emails. By Email messages are data objects with some logic to prepare emails to be sent. Without configuration, the Symfony Serializer serializes Emails with too many data (and triggers some unneeded validation). This PR aims to fix the above issue and at the same time makes serialized emails as small as possible and as readable as possible. Commits ------- 9d869b1 Fix Mime message serialization
…on (fabpot) This PR was merged into the 5.2-dev branch. Discussion ---------- [Serializer][Mime] Fix Mime message serialization | Q | A | ------------- | --- | Branch? | master <!-- see below --> | Bug fix? | yes | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix symfony#37414, Fix symfony#37324 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | n/a Symfony serialization is used by Messenger to serialize Emails. By Email messages are data objects with some logic to prepare emails to be sent. Without configuration, the Symfony Serializer serializes Emails with too many data (and triggers some unneeded validation). This PR aims to fix the above issue and at the same time makes serialized emails as small as possible and as readable as possible. Commits ------- 9d869b1 Fix Mime message serialization
Recent changes in symfony/mailer@f62d7eb#diff-bb5be03f312bba64e0ce7d4cbbdbf7a8 (avoiding reuse of same var names when cloning) introduced an issue where, if an EventDispatcher is available, the cloned message is not dispatched to the MessageBus anymore.
Instead, the original message is dispatched, resulting in listener behaviour (e.g.
\Symfony\Component\Mailer\EventListener\MessageListener) not affecting the message passed to the MessageBus.This PR passes the cloned messages back to the original
$messagevariable.Alternatively, the original commit by @fabpot could be reverted. Changes in this PR however make it more explicit.