[HttpFoundation] Allow null in InputBag@set
#37326
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows `null` to be passed to InputBag's `set` method.
null in InputBag@setnull in InputBag@set
|
see also #37100, we discussed it quite recently.
Previously it was an instance of ParameterBag. i still think this is legit, as it allows for using decoded JSON payloads :) im not sure about hiding empty strings this way, but that's a user concern i guess. |
|
@ro0NL Yes, exactly. Laravel users greatly enjoy this feature. |
|
I can imagine. Symfony's Form component more or less does the same, on a different layer. |
GrahamCampbell
suggested changes
Jun 17, 2020
GrahamCampbell
suggested changes
Jun 17, 2020
|
I have updated the deprecation message. |
heavensloop
reviewed
Jun 17, 2020
|
Should I retarget this to 5.1 branch on this PR? |
|
Yes, you should retarget your patch branch to 5.1 |
|
Opened against 5.1 here: #37327 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
nullto be passed to InputBag'ssetmethod.Previously,
nullwas an allowed value to the InputBag'ssetmethod. At some point this was deprecated. It would be very nice for us to be able to set this tonull. For example, this ability drives a very popular feature of Laravel where we ship a middleware that converts all empty strings tonullon incoming requests.Note that the
getmethod already specifically allowsnullandnullis a valid decoded JSON value.