Directly use the driverConnection executeUpdate method #37358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
Jun 24, 2020
|
@derrabus Hey, I tried but I don't know if I can easily simulate a master-slave connection with read-only slaves easily with the CI. If you have any clue on how to proceed, I'd be happy to do it! |
|
🤔 I don't have a good idea either. |
fabpot
approved these changes
Jun 25, 2020
|
Thank you @TristanPouliquen. |
|
Thanks @TristanPouliquen |
This was referenced Jul 24, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
executeUpdate & executeQuery methods do not throw a TableNotFoundException. No need for the try/catch as it is done for executeQuery
As explained in #37355, when doing a write operation, one should avoid using the
executeQuerymethod of a Connection, as Doctrine's MasterSlaveConnection can pick a slave instance (usually read-only) for these operations.