[HttpClient] Support for cURL handler objects #37379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
derrabus
commented
Jun 22, 2020
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #37378 |
| License | MIT |
| Doc PR | N/A |
|
Note: The php 8 build on Travis will fail until php/php-src@26171c3 lands in their nightly build. I've run the tests locally. |
nikic
reviewed
Jun 22, 2020
| @@ -347,7 +347,7 @@ public function reset() | |||
| } | |||
|
|
|||
| foreach ($this->multi->openHandles as [$ch]) { | |||
| if (\is_resource($ch)) { | |||
| if (\is_resource($ch) || $ch instanceof \CurlHandle) { | |||
There was a problem hiding this comment.
Just wondering, why are these is_resource checks necessary in the first place? Are they getting closed somehow without being removed?
There was a problem hiding this comment.
Good question indeed. I haven't found a reason why $ch should be anything else than a cURL handle. And the tests still pass if I remove the two guard clauses.
Maybe @nicolas-grekas knows more about why we need(ed?) this check.
There was a problem hiding this comment.
I've seen strange things happen at destructing/shutdown time, this might be related.
nicolas-grekas
approved these changes
Jun 22, 2020
fabpot
approved these changes
Jun 24, 2020
|
Thank you @derrabus. |
This was referenced Jul 24, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.