[Mime] switching source of mime types from Apache to "MIME-db" #37422

desarrolla2 · 2020-06-26T08:30:25Z

Q	A
Branch?	master
Bug fix?	no
New feature?	no
Deprecations?	no
Tickets	Fix #37412
License	MIT
Doc PR	no

desarrolla2 · 2020-06-26T08:33:02Z

I preferred to use the "v1.44.0" tag instead of master because they recommend it, since there may be json format changes in the future.

Maybe you prefer that I use master branch and this script fails, if format changes.

fabpot · 2020-06-26T08:35:22Z

Great! Can you apply fabbot's patch? Also, can you run the script to see the diff with what we have now?

nicolas-grekas · 2020-06-26T09:00:09Z

src/Symfony/Component/Mime/MimeTypes.php

        'audio/mp2' => ['mp2'],
        'audio/mp3' => ['mp3', 'mpga'],
        'audio/mp4' => ['m4a', 'mp4a', 'f4a'],
-        'audio/mpeg' => ['mp3', 'mpga', 'mp2', 'mp2a', 'm2a', 'm3a'],
+        'audio/mpeg' => ['mpga', 'mp2', 'mp2a', 'mp3', 'm2a', 'm3a'],


related to #37389, mp3 should be first?

Yes, it's the most common format. You can also add mp1 like defined here (page3).

@YaFou could you please report this to https://github.com/jshttp/mime-db? Maybe send them a PR also?

I will do that this evening!

@nicolas-grekas: see jshttp/mime-db#201.

@YaFou can you revert this change, maybe adding a comment like // mp3 should be first
same in other places where I commented about ordering?
that'd allow unlocking this PR

I meant @desarrolla2 sorry

@nicolas-grekas do you want that:

a) I put the extensions in the order that you comment at MimeTypes.php
b) I update the script update_mime_types.php to force that order after download sources
c) I add comments with your suggestions at MimeTypes.php

I think b) would be good. Then the comments would be found in update_mime_types.php only.

nicolas-grekas · 2020-06-26T09:01:17Z

src/Symfony/Component/Mime/MimeTypes.php

@@ -1460,7 +1587,7 @@ public function guessMimeType(string $path): ?string
        'text/x-lua' => ['lua'],
        'text/x-lyx' => ['lyx'],
        'text/x-makefile' => ['mk', 'mak'],
-        'text/x-markdown' => ['md', 'mkd', 'markdown'],
+        'text/x-markdown' => ['mkd', 'md', 'markdown'],


if the 1st is the most used, then md should be first?
does the order mean something in the source db?

For reference, the source DB uses this preference for merging the multiple sources:

// source preference (least -> most) var preference = ['nginx', 'apache', undefined, 'iana']

nicolas-grekas · 2020-06-26T09:02:47Z

src/Symfony/Component/Mime/MimeTypes.php

@@ -334,18 +368,23 @@ public function guessMimeType(string $path): ?string
        'application/vnd.antix.game-component' => ['atx'],
        'application/vnd.appimage' => ['appimage'],
        'application/vnd.apple.installer+xml' => ['mpkg'],
-        'application/vnd.apple.keynote' => ['key'],
+        'application/vnd.apple.keynote' => ['keynote', 'key'],


key should be first ?

nicolas-grekas · 2020-06-26T09:06:59Z

Thanks for working on this.
About my comments above related to ordering, maybe we should send them to the upstream db?

src/Symfony/Component/Mime/Resources/bin/update_mime_types.php

desarrolla2 · 2020-07-03T10:41:10Z

should i rebase the commit to improve the history?

stof · 2020-07-03T12:28:12Z

@desarrolla2 yes please

nicolas-grekas · 2020-07-04T09:52:34Z

src/Symfony/Component/Mime/MimeTypes.php

@@ -2377,20 +2568,25 @@ public function guessMimeType(string $path): ?string
        'msf' => ['application/vnd.epson.msf'],
        'msg' => ['application/vnd.ms-outlook'],
        'msh' => ['model/mesh'],
-        'msi' => ['application/x-msdownload', 'application/x-msi'],
+        'msi' => ['application/octet-stream', 'application/x-msdownload', 'application/x-msi'],


I've checked the source and I think we should always list 'application/octet-stream' last.
Alternatively, we should just skip it. The reason is that we already fallback to 'application/octet-stream' by default in DataPart. For sure, listing it first is going to be a regression.

@nicolas-grekas you prefer that:

a) I put 'application/octet-stream' last.
b) I skip 'application/octet-stream'

Skipping would be best IMHO

src/Symfony/Component/Mime/Resources/bin/update_mime_types.php

fabpot · 2020-07-15T07:11:44Z

@desarrolla2 I've fixed your last commit.

nicolas-grekas · 2020-07-15T08:29:16Z

Thank you @desarrolla2.

carsonbot added Status: Needs Review Mime labels Jun 26, 2020

nicolas-grekas reviewed Jun 26, 2020

View reviewed changes

stof mentioned this pull request Jun 26, 2020

Reorder the markdown extensions jshttp/mime-db#200

Closed

YaFou mentioned this pull request Jun 26, 2020

Sort audio/mpeg file extensions to the most common one jshttp/mime-db#201

Closed

YaFou reviewed Jun 26, 2020

View reviewed changes

src/Symfony/Component/Mime/Resources/bin/update_mime_types.php Outdated Show resolved Hide resolved

juanmrad reviewed Jun 29, 2020

View reviewed changes

src/Symfony/Component/Mime/Resources/bin/update_mime_types.php Show resolved Hide resolved

nicolas-grekas added this to the next milestone Jun 30, 2020

desarrolla2 force-pushed the ticket_37412 branch 2 times, most recently from 1fcb68b to 50c18e5 Compare July 4, 2020 07:35

nicolas-grekas reviewed Jul 4, 2020

View reviewed changes

desarrolla2 force-pushed the ticket_37412 branch from cbe8e5c to f727277 Compare July 6, 2020 12:25

nicolas-grekas reviewed Jul 6, 2020

View reviewed changes

src/Symfony/Component/Mime/Resources/bin/update_mime_types.php Outdated Show resolved Hide resolved

desarrolla2 force-pushed the ticket_37412 branch from f727277 to ea2dd96 Compare July 10, 2020 09:43

fabpot force-pushed the ticket_37412 branch 2 times, most recently from ab5f2c6 to c74edb5 Compare July 15, 2020 07:10

fabpot approved these changes Jul 15, 2020

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels Jul 15, 2020

[Mime] switching source of mime types from Apache to "MIME-db"

ebea452

nicolas-grekas force-pushed the ticket_37412 branch from c74edb5 to ebea452 Compare July 15, 2020 08:28

nicolas-grekas merged commit 5a61446 into symfony:master Jul 15, 2020

nicolas-grekas modified the milestones: next, 5.2 Oct 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Mime] switching source of mime types from Apache to "MIME-db" #37422

[Mime] switching source of mime types from Apache to "MIME-db" #37422

desarrolla2 commented Jun 26, 2020

desarrolla2 commented Jun 26, 2020 •

edited

Loading

fabpot commented Jun 26, 2020

nicolas-grekas Jun 26, 2020 •

edited

Loading

YaFou Jun 26, 2020

nicolas-grekas Jun 26, 2020

YaFou Jun 26, 2020

YaFou Jun 26, 2020

nicolas-grekas Jun 30, 2020

nicolas-grekas Jun 30, 2020 •

edited

Loading

desarrolla2 Jun 30, 2020

nicolas-grekas Jun 30, 2020

nicolas-grekas Jun 26, 2020

javiereguiluz Jun 26, 2020

nicolas-grekas Jun 26, 2020

nicolas-grekas commented Jun 26, 2020 •

edited

Loading

desarrolla2 commented Jul 3, 2020

stof commented Jul 3, 2020

nicolas-grekas Jul 4, 2020 •

edited

Loading

desarrolla2 Jul 6, 2020

nicolas-grekas Jul 6, 2020

fabpot commented Jul 15, 2020

nicolas-grekas commented Jul 15, 2020

[Mime] switching source of mime types from Apache to "MIME-db" #37422

[Mime] switching source of mime types from Apache to "MIME-db" #37422

Conversation

desarrolla2 commented Jun 26, 2020

desarrolla2 commented Jun 26, 2020 • edited Loading

fabpot commented Jun 26, 2020

nicolas-grekas Jun 26, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nicolas-grekas Jun 30, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nicolas-grekas commented Jun 26, 2020 • edited Loading

desarrolla2 commented Jul 3, 2020

stof commented Jul 3, 2020

nicolas-grekas Jul 4, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fabpot commented Jul 15, 2020

nicolas-grekas commented Jul 15, 2020

desarrolla2 commented Jun 26, 2020 •

edited

Loading

nicolas-grekas Jun 26, 2020 •

edited

Loading

nicolas-grekas Jun 30, 2020 •

edited

Loading

nicolas-grekas commented Jun 26, 2020 •

edited

Loading

nicolas-grekas Jul 4, 2020 •

edited

Loading