Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[ErrorHandler][DebugClassLoader] Add mixed and static return types support #37586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2020
Merged

[ErrorHandler][DebugClassLoader] Add mixed and static return types support #37586

merged 1 commit into from
Aug 16, 2020

Conversation

fancyweb
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the next milestone Jul 15, 2020
@fabpot
Copy link
Member

fabpot commented Aug 11, 2020

Is it something that needs to be merged in an older branch instead?

@fancyweb
Copy link
Contributor Author

I considered this a new feature. I don't remember your policy for supporting new PHP versions features.

@fabpot
Copy link
Member

fabpot commented Aug 11, 2020

Right now, we add support for newest PHP versions in the lowest maintained version, that's why I'm asking.

@fancyweb
Copy link
Contributor Author

I need to rebase on 4.4 then, do you agree?

@fabpot
Copy link
Member

fabpot commented Aug 11, 2020

Yes, please.

@fancyweb fancyweb changed the base branch from master to 4.4 August 11, 2020 12:16
@fancyweb fancyweb force-pushed the error-handler-debug-class-loader-php-8-return-types branch from 52dea2d to 0533f1f Compare August 11, 2020 12:16
@fabpot
Copy link
Member

fabpot commented Aug 16, 2020

Thank you @fancyweb.

@fabpot fabpot merged commit d6b9936 into symfony:4.4 Aug 16, 2020
@fancyweb fancyweb deleted the error-handler-debug-class-loader-php-8-return-types branch August 17, 2020 07:02
This was referenced Aug 31, 2020
Merged
Merged
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.2 Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@dunglas dunglas Awaiting requested review from dunglas

@jderusse jderusse Awaiting requested review from jderusse

@lyrixx lyrixx Awaiting requested review from lyrixx

@sroze sroze Awaiting requested review from sroze

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
ErrorHandler Feature Status: Needs Review
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
4 participants
@fancyweb @fabpot @nicolas-grekas @carsonbot