Allow doctrine/persistence 2 #37639
Merged
Allow doctrine/persistence 2 #37639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c447008 to
c85fc0c
Compare
c85fc0c to
6c0f312
Compare
alcaeus
approved these changes
Jul 23, 2020
This PR was merged into the 3.4 branch. Discussion ---------- [Lock][Cache] Fix Redis tests | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | / | License | MIT | Doc PR | / In branch 3.4, travis started a redis-server container and tests run correctly. Starting from 4.4, the travis test suite don't start the server anymore, which is not an issue for 4.4's tests because tests are skiped. The issue is when branch 4.4 run the 3.4's test suite to check if component changes in 4.4 does not affect 3.4. in that case, the 3.4 tests suite is run without redise-server. see https://travis-ci.org/github/symfony/symfony/jobs/711062047 for example This PR replace the error handler (didn't worked) by catching the exception in a similar way than symfony#36647 Commits ------- f524c85 Fix Redis tests
…rabus) This PR was merged into the 3.4 branch. Discussion ---------- [DoctrineBridge] Bump doctrine/data-fixtures | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A Discovered while working on symfony#37639: DoctrineBridge is locked to an old an unmaintained branch of `doctrine/data-fixtures`. This is going to be a problem as soon as we want to support `doctrine/persistence` 2. Commits ------- 4b61101 [DoctrineBridge] Bump doctrine/data-fixtures.
* 3.4: Fix Redis tests [DoctrineBridge] Bump doctrine/data-fixtures.
6c0f312 to
cd22fe6
Compare
|
Thank you @derrabus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #37416.
This PR unblocks the installation of
doctrine/persistenceversion 2.Notes:
doctrine/data-fixturesbecause composer would otherwise downgrade to an ancient alpha release with incomplete version constraints. This package is a dev dependency for our tests, so I think we're good here.edit: Moved to [DoctrineBridge] Bump doctrine/data-fixtures #37640.
doctrine/persistence.