Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allow array keys for collection types #37646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Allow array keys for collection types #37646

wants to merge 1 commit into from

Conversation

patrickbussmann
Copy link

Q A
Branch? master for features
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #7828
License MIT
Doc PR symfony/symfony-docs#13994

I found a bad mistake when I work with bigger symfony form objects.
The house example of @kokers is very good.
#7828 (comment)

So the hidden _id field is now a index_name option 🙂

@patrickbussmann patrickbussmann requested a review from xabbuh as a code owner July 23, 2020 21:39
@patrickbussmann patrickbussmann force-pushed the feature-allow-collection-keys branch from e0dcab0 to ad7ceec Compare July 23, 2020 21:47
@patrickbussmann patrickbussmann force-pushed the feature-allow-collection-keys branch from ad7ceec to e30f01c Compare July 23, 2020 21:49
@xabbuh xabbuh added the Form label Jul 24, 2020
@xabbuh xabbuh added this to the next milestone Jul 24, 2020
@javiereguiluz javiereguiluz mentioned this pull request Sep 12, 2020
Closed
@fabpot fabpot closed this Oct 7, 2020
@fabpot
Copy link
Member

fabpot commented Oct 7, 2020

We've just moved away from master as the main branch to use 5.x instead. Unfortunately, I cannot reopen the PR and change the target branch to 5.x. Can you open a new PR referencing this one to not loose the discussion? Thank you for your understanding and for your help.

@nicolas-grekas nicolas-grekas modified the milestones: 5.x, 5.2 Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Feature for 5.x Form Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

[Form] Extend CollectionType to handle custom keys
5 participants
@patrickbussmann @fabpot @nicolas-grekas @xabbuh @carsonbot