[Messenger] Fix invalid option sslmode in AmazonSqs bridge #37654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cea413e to
fa8672b
Compare
jderusse
commented
Jul 24, 2020
| @@ -94,6 +95,19 @@ public static function fromDsn(string $dsn, array $options = [], HttpClientInter | |||
| if (isset($parsedUrl['query'])) { | |||
| parse_str($parsedUrl['query'], $query); | |||
| } | |||
|
|
|||
| // check for extra keys in options | |||
| $optionsExtraKeys = array_diff(array_keys($options), array_keys(self::DEFAULT_OPTIONS)); | |||
There was a problem hiding this comment.
moved the checks before the merge of $options = $query + $options to distinguish errors in option and dsn.
maybe it doesn't worth it, and we should just keep the first check on options
stof
reviewed
Jul 24, 2020
src/Symfony/Component/Messenger/Bridge/AmazonSqs/Transport/Connection.php
Show resolved
Hide resolved
fa8672b to
afbd51b
Compare
|
Tested your changes locally (have same problem) and worked for me 👍 |
migo315
added a commit
to bestit/amazon-sqs-messenger
that referenced
this pull request
Jul 30, 2020
fabpot
approved these changes
Jul 31, 2020
|
Thank you @jderusse. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sslmode option allows people to use AmazonSqs with non-offical endpoint like the asyncaws/testing-sqs docker image
By fixing precedence of DNS options in #37269 I introduced a bug that trigger an exception
Unknown option found: [sslmode]. I apologize for thisThis PR adds
sslmodein list of allowed options