DependencyInjection: added missing use $container #37665
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As highlighted in the failing test case, there are situations where the |
|
Hi Nicolas, Of course. Here you can will find an example project. https://github.com/DarkyMuc/symfony_di_example After you call this project via browser, you receive the error "Notice: Undefined variable: container" I think it's the combination of shared: false and lazy: true in the service.yaml. Greetings Markus |
|
Thanks for all the details, fixed in #37953 |
fabpot
added a commit
that referenced
this pull request
Aug 26, 2020
This PR was merged into the 5.1 branch. Discussion ---------- [DI] fix dumping lazy non-shared services | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #37665 | License | MIT | Doc PR | - Commits ------- a4f4ca7 [DI] fix dumping lazy non-shared services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use not shared services, $container was not shared in closure. Error-Message: Notice: Undefined variable: $container