[VarDumper] Support PHPUnit --colors option #37840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ogizanagi
commented
Aug 14, 2020
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Tickets | N/A |
| License | MIT |
| Doc PR | N/A |
fabpot
requested changes
Aug 16, 2020
| @@ -522,12 +522,14 @@ protected function supportsColors() | |||
| case '--color=yes': | |||
| case '--color=force': | |||
| case '--color=always': | |||
| case '--colors=always': | |||
There was a problem hiding this comment.
Does --colors also support yes and force as a value?
There was a problem hiding this comment.
Nope, it doesn't: https://phpunit.readthedocs.io/en/9.3/textui.html?highlight=--colors#command-line-options
The only three values supported are auto, never and always:
https://github.com/sebastianbergmann/phpunit/blob/19e27be279ab0056984a42f93dace950d9116ba7/src/TextUI/DefaultResultPrinter.php#L65
fabpot
reviewed
Aug 16, 2020
| return static::$defaultColors = true; | ||
|
|
||
| case '--no-ansi': | ||
| case '--color=no': | ||
| case '--color=none': | ||
| case '--color=never': | ||
| case '--colors=never': |
There was a problem hiding this comment.
Same here, I think it supports all possible values as well.
fabpot
approved these changes
Aug 16, 2020
|
Thank you @ogizanagi. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.