[VarDumper] Backport handler lock when using VAR_DUMPER_FORMAT #37841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Aug 16, 2020
|
Thank you @ogizanagi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of the "lock" behavior from #35967, preventing unexpected handler change when using the
VAR_DUMPER_FORMATenv var.As a concrete example of this not working as expected:
Start a PHPUnit test suite with this env var to the desired format. If a web test case is making a request (with debug enabled), the
DebugBundlereplaces the handler set initially by theVAR_DUMPER_FORMAT, will collect dumps into the profiler, but won't output these.As well, for dumps made in between the the kernel is boot (
DebugBundle::build()is called) and a request, the dumps are properly sent to the output with expected format, but looses colors.IMHO, the use-cases of
VAR_DUMPER_FORMATjustifies locking the handler for the whole process.