[PhpUnit] Add polyfill for assertMatchesRegularExpression() #37960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
reviewed
Aug 27, 2020
GromNaN
reviewed
Aug 27, 2020
fabpot
approved these changes
Aug 27, 2020
fabpot
approved these changes
Aug 27, 2020
|
Thank you @dunglas. |
8cfc0d2 to
33eccd2
Compare
|
This has been merged already in master in #37567 |
|
I'd suggest reverting + using master @dunglas |
|
I thought we were merging this kind of features in the lowest branch. |
|
This one has been merged in 4.4 so I was confused :) #36408 |
fabpot
added a commit
that referenced
this pull request
Aug 27, 2020
…olyfillAssertTrait (dunglas) This PR was merged into the 4.4 branch. Discussion ---------- [PhpUnitBridge] Move assertMatchesRegularExpression in PolyfillAssertTrait | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | n/a Move the polyfill method introduced in #37960 in the `Assert` trait. Sorry I noticed this trait later. Commits ------- 0426113 [PhpUnitBridge] Move assertMatchesRegularExpression in PolyfillAssertTrait
fabpot
added a commit
that referenced
this pull request
Aug 28, 2020
This PR was merged into the 4.4 branch. Discussion ---------- [PhpUnitBridge] Polyfill new phpunit 9.1 assertions | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #37320 | License | MIT | Doc PR | - Backport of #37567, follows the discussion on #37960. Commits ------- d945b88 [PhpUnitBridge] Polyfill new phpunit 9.1 assertions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assertRegExp()is now deprecated in favor ofassertMatchesRegularExpression.