[HttpKernel] Do not override max_redirects option in HttpClientKernel #38212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing integration test |
fabpot
requested changes
Sep 17, 2020
| @@ -19,6 +19,7 @@ | |||
| "php": ">=7.1.3", | |||
| "symfony/error-handler": "^4.4", | |||
| "symfony/event-dispatcher": "^4.4", | |||
| "symfony/http-client-contracts": "^4.4", | |||
There was a problem hiding this comment.
Constraint is wrong here, should be ^1.1|^2
There was a problem hiding this comment.
Fixed with 1cc8fc2.
fabpot
reviewed
Sep 17, 2020
nicolas-grekas
approved these changes
Sep 17, 2020
fabpot
approved these changes
Sep 17, 2020
1cc8fc2 to
981a11b
Compare
|
Thank you @dmolineus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed by @nicolas-grekas this pull request removes the
max_redirectssetting in the\Symfony\Component\HttpKernel\HttpClientKernel::handlemethod.It solves the issue that requests made by the
\Symfony\Component\HttpClient\CachingHttpClientwouldn't follow redirects as described in the linked issue.