[Validator] Add normalizer option to Unique constraint #38488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e4ed9f6 to
3205952
Compare
derrabus
requested changes
Feb 21, 2021
src/Symfony/Component/Validator/Constraints/UniqueValidator.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Validator/Constraints/UniqueValidator.php
Outdated
Show resolved
Hide resolved
db37354 to
00b2a49
Compare
derrabus
requested changes
Mar 1, 2021
| @@ -16,6 +16,14 @@ | |||
| use Symfony\Component\Validator\Exception\UnexpectedValueException; | |||
| use Symfony\Component\Validator\Test\ConstraintValidatorTestCase; | |||
|
|
|||
| class CallableClass | |||
There was a problem hiding this comment.
Please declare the test case class first. This fixture class should be moved to the end of the file.
src/Symfony/Component/Validator/Tests/Constraints/UniqueValidatorTest.php
Outdated
Show resolved
Hide resolved
602ed32 to
03b91f7
Compare
derrabus
approved these changes
Mar 16, 2021
fabpot
approved these changes
Mar 17, 2021
|
@henry2778 Can you have a look at the failing tests? It seems related to the changes here. Thank you. |
thanks! fixed |
51c36bf to
44e1e8b
Compare
|
Thank you @henry2778. |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Mar 27, 2021
…henry2778) This PR was squashed before being merged into the 5.3-dev branch. Discussion ---------- [Validator] Add normalizer option to Unique constraint Hello. Documenting the feature symfony/symfony#38488 about `normalizer` option for Unique constraint. 1. Updated the intro paragraph mentioning the strict comparison 2. Added normalizer to the option list 3. Added normalizer option description. There is a include file for that, but since the description is slightly different, I decided not use it. Thanks! Commits ------- 92072d9 [Validator] Add normalizer option to Unique constraint
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Reopening my PR #37507 with target branch
5.xThis PR is about #37451. The idea is to make that constraint more flexible and able to process business rules, especially when working with objects. We can think about it as the similar feature in UniqueEntity constraint, when we declare on which attributes we are applying the constraint. But in our case it is more general - we pass a callable with whatever logic we want to apply to collection elements before we apply 'uniqueness check' :)
Looks like no BC breaks. Thanks! :)