Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[RateLimiter] Allow configuration value "no_limit" #38665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2020
Merged

[RateLimiter] Allow configuration value "no_limit" #38665

merged 1 commit into from
Oct 22, 2020

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Oct 21, 2020

Q A
Branch? 5.x
Bug fix? maybe?
New feature? not sure
Deprecations?
Tickets
License MIT
Doc PR

I dont see any reason why we should allow people to configure "no_limit". I assume this was just forgotten.

@Nyholm Nyholm requested a review from wouterj October 21, 2020 21:22
wouterj
wouterj approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I indeed didn't intentionally forbid this.

@chalasr chalasr added this to the 5.2 milestone Oct 22, 2020
@chalasr chalasr force-pushed the ratelimiter-no-limit branch from 42c2ccd to 2b9058d Compare October 22, 2020 08:35
@chalasr
Copy link
Member

chalasr commented Oct 22, 2020

Thank you Tobias.

@chalasr chalasr merged commit 58f4e9d into symfony:5.x Oct 22, 2020
@fabpot fabpot mentioned this pull request Oct 28, 2020
Merged
@MatTheCat MatTheCat mentioned this pull request Nov 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug RateLimiter Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Nyholm @chalasr @wouterj @carsonbot