Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Serializer] Exclude non-initialized properties accessed with getters #38899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 60 commits into from
Closed

[Serializer] Exclude non-initialized properties accessed with getters #38899

wants to merge 60 commits into from

Conversation

BoShurik
Copy link
Contributor

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets no
License MIT
Doc PR symfony/symfony-docs#...

Allow to serialize

final class Php74DummyPrivate
{
    private string $uninitializedProperty;

    private string $initializedProperty = 'defaultValue';

    public function getUninitializedProperty(): string
    {
        return $this->uninitializedProperty;
    }

    public function getInitializedProperty(): string
    {
        return $this->initializedProperty;
    }
}

Similar to #34791

@BoShurik BoShurik requested a review from dunglas as a code owner October 30, 2020 14:44
@carsonbot carsonbot added this to the 3.4 milestone Oct 30, 2020
@BoShurik BoShurik changed the title Exclude non-initialized properties accessed with getters [Serializer] Exclude non-initialized properties accessed with getters Oct 30, 2020
@derrabus derrabus modified the milestones: 3.4, 4.4 Oct 30, 2020
@derrabus
Copy link
Member

Hello and thank you for your pull request. Unfortunately, the 3.4 branch has been closed for bugfixes already. Please check if the problem you're trying to solve is also present on the 4.4 branch. If that is the case, please rebase your PR to 4.4.

Nyholm and others added 21 commits October 30, 2020 17:53
@Nyholm @BoShurik
[CI] Silence errors when remove file/dir on test tearDown()
2c81aaf
@BattleRattle @BoShurik
[HttpFoundation] Fix Range Requests
b64fd67
@maxime-aknin @BoShurik
Fix Reflection file name with eval()\'d code
4a0d273 
remove eval()\'d code from lineage
@jt2k @BoShurik
[WebProfilerBundle] Hide debug toolbar in print view
9b7ca12
@xabbuh @BoShurik
indexBy does not refer to attributes, but to column names
817ba44
@wouterj @BoShurik
Added dutch translations for new invalid messages
efa9ca8
@fabpot @BoShurik
[Form] Sync translations
b99c207
@Nyholm @BoShurik
[Filesystem] Check if failed unlink was caused by permission denied
eaefd2a
@marmichalski @BoShurik
[Validator] Add missing romanian translations
e1bfe92
@zghosts @BoShurik
add missing dutch translations
9f0091c
@BoShurik
[Serializer] fix decoding float XML attributes starting with 0
b13b246
@nicolas-grekas @BoShurik
Remove branch-version (keep them for contracts only)
a909622
@marmichalski @BoShurik
[Security] Add missing polish translations
63813dd
@marmichalski @BoShurik
[Form] Add missing polish translations
803c0ab
@derrabus @BoShurik
[Security] Synchronized translations with 5.x.
9ad3c75
@derrabus @BoShurik
[Form] Added missing German translations.
56d9bd3
@derrabus @BoShurik
[Security] Added missing German translations.
964ed1f
@zairigimad @BoShurik
Update Security Frensh Translations
d539576
@tarlepp @BoShurik
Added missing security.fi.xlf translation file
83323eb
@zairigimad @BoShurik
Update Security Arabic Translations
edb2ceb
@zairigimad @BoShurik
Update Arabic Form Translations
7fa9a56
zairigimad and others added 24 commits October 30, 2020 17:54
@zairigimad @BoShurik
Update French Translations for Validator Component
9ff0bb6
@IndraGunawan @BoShurik
sync id translation
33ad1d6
@TavoNiievez @BoShurik
[Validator] Added missing Spanish translations.
86b5c27
@Ippey @BoShurik
Add missing translations for Japanese.
7d9549b
@nicolas-grekas @BoShurik
Disable platform checks
a598212
@nicolas-grekas @BoShurik
[travis] Fix location of composer home
19576e3
@a-shafaat @BoShurik
[Form, Security, Validator] Add missing Persian translations (fa_IR)
29f502b
@BoShurik
[Security] Add missing Slovak translations.
14c3093
@BoShurik
[Validator] Add missing Slovak translations.
4fde140
@JohJohan @BoShurik
38737 add missing dutch translation
27a0160
@TavoNiievez @BoShurik
[Form] Added missing Spanish translations.
b1f0de6
@Comrade42 @BoShurik
[Form] Add missing translations for Ukrainian (uk)
b374718
@ahmed-bhs @BoShurik
[Form, Security, Validator] Add missing Turkish translations (tr)
e485a5b
@abame @BoShurik
[Translation] added missing Albanian translations
c62bad4
@Comrade42 @BoShurik
[Security] Add missing translations for Ukrainian (uk)
d7886b3
@Comrade42 @BoShurik
[Validator] Add missing translations for Ukrainian (uk)
d0ce2cf
@Comrade42 @BoShurik
[Form] Fix wrong translations for Ukrainian (uk)
88efb8b
@jderusse @BoShurik
Fix transient tests
a524423
@Nyholm @BoShurik
[Form] Some minor teaks for Swedish
a5a85fa
@nicolas-grekas @BoShurik
Fix CI for 3.4
e89b5bb
@fd6130 @BoShurik
Missing translations for Chinese (zh_CN) #38732
330db7f
@fd6130 @BoShurik
Missing translations for Chinese (zh_TW) #38733
3a3a2b7
@fabpot @BoShurik
Update CONTRIBUTORS for 3.4.46
924bbb3
@BoShurik
Exclude non-initialized properties accessed with getters
e3501c0
@BoShurik BoShurik changed the base branch from 3.4 to 4.4 October 30, 2020 14:55
@BoShurik BoShurik closed this Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@wouterj wouterj Awaiting requested review from wouterj wouterj is a code owner

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

Assignees
No one assigned
Labels
Bug Serializer Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.