[Messenger][SQS] Make sure one can enable debug logs #38998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
commented
Nov 5, 2020
|
|
||
| Connection::fromDsn('sqs://default', ['bar' => 'bar']); | ||
| } | ||
|
|
||
| public function testFromDsnWithInvalidQueryStringAndOption() | ||
| { | ||
| $this->expectException(\InvalidArgumentException::class); | ||
| $this->expectExceptionMessage('Unknown option found: [bar]. Allowed options are [buffer_size, wait_time, poll_timeout, visibility_timeout, auto_setup, access_key, secret_key, endpoint, region, queue_name, account, sslmode].'); |
There was a problem hiding this comment.
I dont want this test to fail every time we add a new option.
stof
reviewed
Nov 5, 2020
Nyholm
commented
Nov 5, 2020
| @@ -312,4 +315,83 @@ public function testGetQueueUrlNotCalled() | |||
|
|
|||
| $connection->delete('id'); | |||
| } | |||
|
|
|||
| public function testLoggerWithoutDebugOption() | |||
There was a problem hiding this comment.
I could replace these tests by just comparing objects of SqsClient and just see if they got the same config... that might be better and more "unit"
jderusse
reviewed
Nov 5, 2020
src/Symfony/Component/Messenger/Bridge/AmazonSqs/Transport/Connection.php
Show resolved
Hide resolved
jderusse
approved these changes
Nov 5, 2020
chalasr
approved these changes
Nov 5, 2020
|
I added change log for 5.3 |
|
Helpful! Thank you Tobias. |
|
Thank you for merging. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you add
&debug=trueon your DSN, then we will useLoggerInterface::debug()to print HTTP requests and responses.This has a negative impact on performance, but it will be helpful when debugging.