[DependencyInjection] Fix circular detection with multiple paths #39058
+183
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28bc9ab to
1c3721e
Compare
chalasr
approved these changes
Nov 11, 2020
|
I have tested this against my reproducer in #39056 and Im pleased to report it fixes the reported issue. |
|
Thanks Jérémy. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently 2 kind of issues related to the Dependency Injection:
performance issue when project contains many loops (Injecting certain services causes O(n) compilation complexity, while injecting Container is O(1) #37850)
Which has been fixed by [DependencyInjection] fix performances in circular refs detection #38882
Infinity loop in some case (Maximum function nesting level of '256' reached with retryable http client and mailer handler #38970)
Which has been fixed by [DependencyInjection] Fix circular reference with Factory + Lazy Iterrator #38980 and [DependencyInjection] Optimize circular collection by removing flattening #39021
The new issue #39056 has been introduced by #38882 (The performance issue refactor) because in order to optimize loop detection, I take a short cut and choose to not collect ALL the circular loop but only the one that matters
I was wrong. All loops matters.
This PR fix my previous refacto to collect ALL the paths, with a low CPU footprint