[DependencyInjection] Fixed incorrect report for private services if required service does not exist #39151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f962ddd to
c86c6e1
Compare
jderusse
reviewed
Nov 23, 2020
c86c6e1 to
b07d72c
Compare
fu22ybear
commented
Nov 29, 2020
src/Symfony/Component/DependencyInjection/Tests/ContainerBuilderTest.php
Show resolved
Hide resolved
jderusse
reviewed
Nov 29, 2020
src/Symfony/Component/DependencyInjection/Tests/ContainerBuilderTest.php
Outdated
Show resolved
Hide resolved
b07d72c to
e5491ab
Compare
e5491ab to
0acbc9e
Compare
0acbc9e to
1461688
Compare
nicolas-grekas
approved these changes
Nov 29, 2020
…required service does not exist
1461688 to
39bd05c
Compare
|
Thank you @Islam93. |
This was referenced Dec 18, 2020
Merged
Merged
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Feb 22, 2024
…ng service locators (nicolas-grekas) This PR was merged into the 5.4 branch. Discussion ---------- [DependencyInjection] Fix computing error messages involving service locators | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? |no | Issues | - | License | MIT I just realized that #39151 broke the logic in CheckExceptionOnInvalidReferenceBehaviorPass because it relied on inlining pass doing its job. This makes the pass work with and without inlining. Commits ------- ca7afaf [DependencyInjection] Fix computing error messages involving service locators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…does not exist
looks like
CheckExceptionOnInvalidReferenceBehaviorPasscan be moved tobeforeRemovingPassessection without any consequences. this solves the problem and all tests still pass