Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Notifier] Fix slack section block #39236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2020
Merged

[Notifier] Fix slack section block #39236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix checking slack section fields limit
  • Loading branch information
@norkunas
norkunas committed Nov 30, 2020
commit 472fa3b50af496154e65ae461569bf26549969eb
2 changes: 1 addition & 1 deletion src/Symfony/Component/Notifier/Bridge/Slack/Block/SlackSectionBlock.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public function text(string $text, bool $markdown = true): self
*/
public function field(string $text, bool $markdown = true): self
{
if (10 === \count($this->options['fields'])) {
if (10 === \count($this->options['fields'] ?? [])) {
throw new \LogicException('Maximum number of fields should not exceed 10.');
}

Expand Down
59 changes: 59 additions & 0 deletions src/Symfony/Component/Notifier/Bridge/Slack/Tests/Block/SlackSectionBlockTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
<?php

/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <[email protected]>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Symfony\Component\Notifier\Bridge\Slack\Tests\Block;

use PHPUnit\Framework\TestCase;
use Symfony\Component\Notifier\Bridge\Slack\Block\SlackImageBlockElement;
use Symfony\Component\Notifier\Bridge\Slack\Block\SlackSectionBlock;

final class SlackSectionBlockTest extends TestCase
{
public function testCanBeInstantiated(): void
{
$section = new SlackSectionBlock();
$section->text('section text');
$section->field('section field');
$section->accessory(new SlackImageBlockElement('https://example.com/image.jpg', 'an image'));

$this->assertSame([
'type' => 'section',
'text' => [
'type' => 'mrkdwn',
'text' => 'section text',
],
'fields' => [
[
'type' => 'mrkdwn',
'text' => 'section field',
],
],
'accessory' => [
'type' => 'image',
'image_url' => 'https://example.com/image.jpg',
'alt_text' => 'an image',
],
], $section->toArray());
}

public function testThrowsWhenFieldsLimitReached(): void
{
$section = new SlackSectionBlock();
for ($i = 0; $i < 10; ++$i) {
$section->field($i);
}

$this->expectException(\LogicException::class);
$this->expectExceptionMessage('Maximum number of fields should not exceed 10.');

$section->field('fail');
}
}