[FrameworkBundle] TextDescriptor::formatControllerLink checked method… #39313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
CI failed because of a |
fabpot
requested changes
Dec 5, 2020
src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/TextDescriptor.php
Outdated
Show resolved
Hide resolved
fabpot
approved these changes
Dec 5, 2020
|
Thank you @fjogeleit. |
This was referenced Dec 18, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…_exists method before it ensures that $controller is not null
Today I tried PHP8 with Symfony 5.2. - by checking my routes with
It throws
The reason is the configured auth route for the login API defined in routes.yaml:
This route has no controller configured and the value of $controller in
TextDescriptor::formatControllerLinkin the FrameworkBundle isnull. This method has a elseif condition withmethod_existswithout a check if $controller is a string or object.In PHP8 this throws an exception/error and did not work. This PR checks that
$controlleris not null before the method_exists check to prevent this failure.I'm not sure how to test this in the existing Testsuite