Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Config] YamlReferenceDumper: No default value required for VariableNode with array example #39336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[Config] YamlReferenceDumper: No default value required for VariableNode with array example #39336

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9104fd4
[Config] YamlReferenceDumper: No default value required for VariableN…
Nyholm Dec 5, 2020
e4f7d98
cs
Nyholm Dec 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[Config] YamlReferenceDumper: No default value required for VariableN… 
…ode with array example
  • Loading branch information
@Nyholm
Nyholm committed Dec 5, 2020
commit 9104fd4539440c937163a0011d2c44a64bc8d8cc
4 changes: 4 additions & 0 deletions src/Symfony/Component/Config/Definition/Dumper/YamlReferenceDumper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
use Symfony\Component\Config\Definition\NodeInterface;
use Symfony\Component\Config\Definition\PrototypedArrayNode;
use Symfony\Component\Config\Definition\ScalarNode;
use Symfony\Component\Config\Definition\VariableNode;
use Symfony\Component\Yaml\Inline;

/**
Expand Down Expand Up @@ -95,6 +96,9 @@ private function writeNode(NodeInterface $node, NodeInterface $parentNode = null
} elseif ($node instanceof EnumNode) {
$comments[] = 'One of '.implode('; ', array_map('json_encode', $node->getValues()));
$default = $node->hasDefaultValue() ? Inline::dump($node->getDefaultValue()) : '~';
} elseif (VariableNode::class === get_class($node) && \is_array($example)) {
// If there is an array example, we are sure we dont need to print a default value
$default = '';
} else {
$default = '~';

Expand Down