[PhpUnitBridge] Lint files with PHP 5.5 #39421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Dec 10, 2020
|
Could we even run the tests with 5.5? |
I tried last night and failed miserably. 🙈 |
|
@nicolas-grekas Can we merge this PR as is? The tests are widely incompatible with php 5.5 and this small linter (that only activates on changes to the bridge) would have been enough to detect the compatibility issues we've had recently. |
nicolas-grekas
approved these changes
Dec 14, 2020
5bc4631 to
0bc15ff
Compare
|
Thank you @derrabus. |
|
After merging up, I've removed the new linter from the 5.x branch again. It doesn't make much sense there. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to make sure that PhpUnitBridge remains compatible with PHP 5.5.
cc @nicolas-grekas @fancyweb