Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Cache] fix setting "read_timeout" when using Redis #39433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2020

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Being inspired by #39431

@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Dec 10, 2020
@nicolas-grekas nicolas-grekas merged commit 9186d14 into symfony:4.4 Dec 10, 2020
@@ -215,6 +214,7 @@ public static function createConnection($dsn, array $options = [])
}
$params['lazy_connect'] = $params['lazy'] ?? true;
$params['connect_timeout'] = $params['timeout'];
$params['read_timeout'] = $params['read_timeout'];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks useless, isn't it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totally... :)

@nicolas-grekas nicolas-grekas deleted the cache-rto branch December 10, 2020 17:55
This was referenced Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants