Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix CS in Changelogs in 5.1 #39435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2020
Merged

Fix CS in Changelogs in 5.1 #39435

merged 1 commit into from
Dec 10, 2020

Conversation

jderusse
Copy link
Member

Q A
Branch? 5.1
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

@carsonbot carsonbot added this to the 5.1 milestone Dec 10, 2020
jderusse
jderusse commented Dec 10, 2020
View reviewed changes
src/Symfony/Component/Messenger/Bridge/Doctrine/Tests/Transport/DoctrineTransportTest.php
@@ -1,13 +1,13 @@
<?php

/*
* This file is part of the symfony project.
*
* (c) Vincent Touzet <[email protected]>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted 🤣

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#30805 for reference

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm.. this file were renamed and git history trapped me. It exists in 4.4 too :(

@nicolas-grekas
Copy link
Member

Thank you @jderusse.

@nicolas-grekas nicolas-grekas merged commit eb1a490 into symfony:5.1 Dec 10, 2020
@jderusse jderusse deleted the fix-changelog-51 branch December 10, 2020 18:06
@jderusse jderusse mentioned this pull request Dec 10, 2020
Merged
chalasr added a commit that referenced this pull request Dec 10, 2020
@chalasr
minor #39437 Fix licence (jderusse)
4ad158e 
This PR was merged into the 4.4 branch.

Discussion
----------

Fix licence

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Backport of #39435 for 4.4 (the file has been renamed and the git history trapped me)

Commits
-------

6d7893c Fix licence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jderusse @nicolas-grekas @carsonbot