Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Lock] Handle store exception on exists check #39471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Lock] Handle store exception on exists check #39471

wants to merge 1 commit into from

Conversation

dzubchik
Copy link
Contributor

@dzubchik dzubchik commented Dec 11, 2020 •
edited
Loading

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #39470
License MIT

Handle exception to preserve expected behavior - one or multiple stores could be unreachable in a moment and combined store will handle this according to strategy.

@dzubchik dzubchik requested a review from jderusse as a code owner December 11, 2020 16:23
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@dzubchik dzubchik force-pushed the prevent-store-exception-break-combined-store branch from 0d1e93a to 59d9f65 Compare December 11, 2020 16:24
@dzubchik dzubchik changed the title Handle store exception on exists check [Lock] Handle store exception on exists check Dec 11, 2020
@dzubchik dzubchik changed the base branch from 5.x to 5.2 December 11, 2020 16:41
@dzubchik dzubchik changed the base branch from 5.2 to 5.x December 11, 2020 16:42
jderusse
jderusse reviewed Dec 11, 2020
View reviewed changes
Copy link
Member

@jderusse jderusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!
This should be fixed in 4.4. Could you please rebase your PR and add a test ?

@jderusse jderusse added this to the 4.4 milestone Dec 11, 2020
@jderusse jderusse added the Lock label Dec 11, 2020
@dzubchik dzubchik closed this Dec 12, 2020
@dzubchik dzubchik deleted the prevent-store-exception-break-combined-store branch December 12, 2020 09:58
@dzubchik
Copy link
Contributor Author

@jderusse can you please re-open request?

@jderusse
Copy link
Member

@jderusse can you please re-open request?

Hello, no I can't: the branch has been deleted (or force-push) and github does not allow reopening the PR.

Could you please create a new PR for 4.4?

@dzubchik
Copy link
Contributor Author

New opened request - #39476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jderusse jderusse jderusse left review comments

@chalasr chalasr Awaiting requested review from chalasr

@sroze sroze Awaiting requested review from sroze

@wouterj wouterj Awaiting requested review from wouterj

@xabbuh xabbuh Awaiting requested review from xabbuh

@yceruto yceruto Awaiting requested review from yceruto

Assignees
No one assigned
Labels
Bug Lock Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

[Lock] CombinedStore do not handle store exceptions on exists call
3 participants
@dzubchik @carsonbot @jderusse