Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Create hy file #39580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Create hy file #39580

wants to merge 1 commit into from

Conversation

azatyan
Copy link
Contributor

@azatyan azatyan commented Dec 20, 2020

Q A
Branch? 5.x for features / 4.4, 5.1 or 5.2 for bug fixes
Bug fix? yes/no
New feature? yes/no
Deprecations? yes/no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

@azatyan azatyan changed the title Create am file Create hy file Dec 20, 2020
@wouterj
Copy link
Member

wouterj commented Dec 20, 2020

Hi!

Thank you for starting these PRs (together with #39578 and #39581). I can't however follow what you're doing: all these PRs seem to translate English to English. In such cases, it isn't needed to create a translation file (if no translation is found, the original string is displayed).

Do you plan on translating these messages? If that's the case, please close the PRs and open as soon as you have some translations (or update the PRs if you want to translate them directly). To keep the PR list organized, we would only like to have PRs that are considered ready for review (they don't have to be 100% complete, just ready for a first review).

If something else has gone wrong and/or you need help, don't hesitate asking for help in this PR or e.g. on Slack (whether it's related to git, github or anything, except from translating, I'm afraid I can't help with Armenian πŸ˜‰ ).

@azatyan
Copy link
Contributor Author

azatyan commented Dec 28, 2020

Hi!

Thank you for starting these PRs (together with #39578 and #39581). I can't however follow what you're doing: all these PRs seem to translate English to English. In such cases, it isn't needed to create a translation file (if no translation is found, the original string is displayed).

Do you plan on translating these messages? If that's the case, please close the PRs and open as soon as you have some translations (or update the PRs if you want to translate them directly). To keep the PR list organized, we would only like to have PRs that are considered ready for review (they don't have to be 100% complete, just ready for a first review).

If something else has gone wrong and/or you need help, don't hesitate asking for help in this PR or e.g. on Slack (whether it's related to git, github or anything, except from translating, I'm afraid I can't help with Armenian πŸ˜‰ ).

Hi bro, I will do it asap. at 2021. Now I am doing some team building for home-made project.
Thanks...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants