Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DoctrineBridge] Fix circular loop with EntityManager #39799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2021
Merged

[DoctrineBridge] Fix circular loop with EntityManager #39799

merged 1 commit into from
Jan 14, 2021

Conversation

jderusse
Copy link
Member

@jderusse jderusse commented Jan 12, 2021 •
edited
Loading

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets fix #39619
License MIT
Doc PR -

This PR fix a segfault in EntityManager by making the LazyEventManager handle EventSubscriber in a lazy way.

Maybe #34200 too

@carsonbot carsonbot added this to the 4.4 milestone Jan 12, 2021
@carsonbot carsonbot changed the title Fix circular loop with EntityManager [DoctrineBridge] Fix circular loop with EntityManager Jan 12, 2021
This was referenced Jan 12, 2021
Closed
Closed
@jderusse jderusse force-pushed the fix-em-loop branch 2 times, most recently from 93881ab to 5f8f645 Compare January 12, 2021 14:56
@jderusse jderusse force-pushed the fix-em-loop branch 3 times, most recently from f2ac22f to 7d1cfac Compare January 12, 2021 16:37
nicolas-grekas
nicolas-grekas approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somuch needed!

@jderusse jderusse force-pushed the fix-em-loop branch 2 times, most recently from fefa4d1 to b488770 Compare January 14, 2021 18:54
@nicolas-grekas
Copy link
Member

Thank you @jderusse.

@nicolas-grekas nicolas-grekas merged commit 2c9a837 into symfony:4.4 Jan 14, 2021
@jderusse jderusse deleted the fix-em-loop branch January 25, 2021 09:17
@nicolas-grekas nicolas-grekas mentioned this pull request Jan 26, 2021
Closed
This was referenced Jan 27, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug DoctrineBridge Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@jderusse @nicolas-grekas @chalasr @carsonbot