Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix problem when SYMFONY_PHPUNIT_VERSION is empty string value #39858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2021
Merged

Fix problem when SYMFONY_PHPUNIT_VERSION is empty string value #39858

merged 1 commit into from
Jan 18, 2021

Conversation

alexander-schranz
Copy link
Contributor

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations?
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

This should fix that when SYMFONY_PHPUNIT_VERSION is set again on empty:

SYMFONY_PHPUNIT_VERSION= vendor/bin/simple-phpunit

it does not error with:

Creating a "phpunit/phpunit" project at "./phpunit--1"


  [UnexpectedValueException]
  Could not parse version constraint .*: Invalid version string ".*"

@carsonbot carsonbot added this to the 4.4 milestone Jan 16, 2021
@carsonbot
Copy link

Hey!

I did a quick review of this PR, I think most things looks good.

I think @ro0NL has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

ro0NL
ro0NL reviewed Jan 17, 2021
View reviewed changes
Copy link
Contributor

@ro0NL ro0NL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can argue about unset SYMFONY_PHPUNIT_VERSION i guess

@alexander-schranz
Copy link
Contributor Author

The change requests by the fabbot are not related to the changes in this PR and not possible for the simple-phpunit script as I think we support here a lower php version.

@fabpot
Copy link
Member

fabpot commented Jan 18, 2021

Thank you @alexander-schranz.

@fabpot fabpot merged commit 6af4446 into symfony:4.4 Jan 18, 2021
@alexander-schranz alexander-schranz deleted the patch-9 branch January 18, 2021 13:44
This was referenced Jan 27, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ro0NL ro0NL ro0NL left review comments

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@derrabus derrabus derrabus approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
7 participants
@alexander-schranz @carsonbot @fabpot @nicolas-grekas @ro0NL @derrabus @xabbuh