[DoctrineBridge] Add username to UserNameNotFoundException #39880
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
This exception is thrown in other places as well. Can you update them too? |
|
@xabbuh I updated all other cases. There are some cases where the username is set on this exception after the fact such as in the following line: I am not sure if these are still needed (they probably are) |
|
Looks like we could update the |
4e23273 to
073a4b0
Compare
|
I added the other two cases |
| @@ -92,7 +95,10 @@ public function refreshUser(UserInterface $user) | |||
|
|
|||
| $refreshedUser = $repository->find($id); | |||
| if (null === $refreshedUser) { | |||
| throw new UsernameNotFoundException('User with id '.json_encode($id).' not found.'); | |||
| $ex = new UsernameNotFoundException('User with id '.json_encode($id).' not found.'); | |||
| $ex->setUsername(json_encode($id)); | |||
There was a problem hiding this comment.
See for example
Here $id is not a string or even string like, while the username field is documented to be a string. I guess UsernameNotFoundException does not convey what the exact error is, because $id is not a username.
src/Symfony/Bridge/Doctrine/Security/User/EntityUserProvider.php
Outdated
Show resolved
Hide resolved
| @@ -92,7 +95,10 @@ public function refreshUser(UserInterface $user) | |||
|
|
|||
| $refreshedUser = $repository->find($id); | |||
| if (null === $refreshedUser) { | |||
| throw new UsernameNotFoundException('User with id '.json_encode($id).' not found.'); | |||
| $ex = new UsernameNotFoundException('User with id '.json_encode($id).' not found.'); | |||
| $ex->setUsername(json_encode($id)); | |||
|
Thank you @qurben. |
Adds username to UserNameNotFoundException when thrown from EntityUserProvider.
In other places there are no tests for this and I am not sure if the current setup even allows asserting if exceptions contain fields, besides the default ones.