Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[FrameworkBundle] add doctrine/persistence as a dev requirement #39968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jan 25, 2021

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #39941 (comment)
License MIT
Doc PR

Otherwise, we are testing something that will never be possible in a real application.

@chalasr
Copy link
Member

chalasr commented Jan 25, 2021

Good catch, thanks @xabbuh.

@chalasr chalasr merged commit 11290f9 into symfony:4.4 Jan 25, 2021
@xabbuh xabbuh deleted the pr-39941 branch January 25, 2021 17:17
@@ -32,6 +32,7 @@
"require-dev": {
"doctrine/annotations": "^1.10.4",
"doctrine/cache": "~1.0",
"doctrine/persistence": "^1.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should allow ^2 as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

derrabus added a commit that referenced this pull request Jan 26, 2021
This PR was merged into the 4.4 branch.

Discussion
----------

allow Doctrine persistence 2 too

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #39968 (review)
| License       | MIT
| Doc PR        |

Commits
-------

11a9e10 allow Doctrine persistence 2 too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants