Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[SecurityBundle] role_names variable instead of roles #40089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2021
Merged

[SecurityBundle] role_names variable instead of roles #40089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[SecurityBundle] role_names variable instead of roles 
replaced the roles variable with role_names in order to fix cache warming

fixes #40087
  • Loading branch information
@wickedOne @nicolas-grekas
wickedOne authored and nicolas-grekas committed Feb 4, 2021
commit 58bb614abdb34a4f7fa2bae559b2a7f5b484828e
2 changes: 1 addition & 1 deletion src/Symfony/Bundle/SecurityBundle/CacheWarmer/ExpressionCacheWarmer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public function isOptional()
public function warmUp($cacheDir)
{
foreach ($this->expressions as $expression) {
$this->expressionLanguage->parse($expression, ['token', 'user', 'object', 'subject', 'roles', 'request', 'trust_resolver']);
$this->expressionLanguage->parse($expression, ['token', 'user', 'object', 'subject', 'roles', 'role_names', 'request', 'trust_resolver']);
}
}
}
4 changes: 2 additions & 2 deletions src/Symfony/Bundle/SecurityBundle/Tests/CacheWarmer/ExpressionCacheWarmerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ public function testWarmUp()
$expressionLang->expects($this->exactly(2))
->method('parse')
->withConsecutive(
[$expressions[0], ['token', 'user', 'object', 'subject', 'roles', 'request', 'trust_resolver']],
[$expressions[1], ['token', 'user', 'object', 'subject', 'roles', 'request', 'trust_resolver']]
[$expressions[0], ['token', 'user', 'object', 'subject', 'roles', 'role_names', 'request', 'trust_resolver']],
[$expressions[1], ['token', 'user', 'object', 'subject', 'roles', 'role_names', 'request', 'trust_resolver']]
);

(new ExpressionCacheWarmer($expressions, $expressionLang))->warmUp('');
Expand Down