Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[FrameworkBundle] Fix freshness checks with boolean parameters on routes #40135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2021
Merged

[FrameworkBundle] Fix freshness checks with boolean parameters on routes #40135

merged 1 commit into from
Feb 10, 2021

Conversation

HypeMC
Copy link
Member

@HypeMC HypeMC commented Feb 9, 2021

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #40017
License MIT
Doc PR -

@carsonbot carsonbot changed the title [FrameworkBundle][Routing] Boolean container parameters for routes trigger cash refresh on each request [FrameworkBundle] [Routing] Boolean container parameters for routes trigger cash refresh on each request Feb 9, 2021
@carsonbot carsonbot added this to the 4.4 milestone Feb 9, 2021
@HypeMC HypeMC changed the title [FrameworkBundle] [Routing] Boolean container parameters for routes trigger cash refresh on each request [FrameworkBundle] [Routing] Boolean container parameters for routes trigger cache refresh on each request Feb 9, 2021
@carsonbot carsonbot changed the title [FrameworkBundle] [Routing] Boolean container parameters for routes trigger cache refresh on each request [FrameworkBundle][Routing] Boolean container parameters for routes trigger cache refresh on each request Feb 9, 2021
nicolas-grekas
nicolas-grekas reviewed Feb 10, 2021
View reviewed changes
@nicolas-grekas nicolas-grekas changed the title [FrameworkBundle][Routing] Boolean container parameters for routes trigger cache refresh on each request [FrameworkBundle] Boolean container parameters for routes trigger cache refresh on each request Feb 10, 2021
@nicolas-grekas nicolas-grekas changed the title [FrameworkBundle] Boolean container parameters for routes trigger cache refresh on each request [FrameworkBundle] Fix freshness checks with boolean parameters on routes Feb 10, 2021
@nicolas-grekas
Copy link
Member

Thank you @HypeMC.

@nicolas-grekas nicolas-grekas merged commit 52a999c into symfony:4.4 Feb 10, 2021
@HypeMC HypeMC deleted the cache-with-container-parameters-for-routes branch February 10, 2021 17:13
This was referenced Mar 4, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

+1 more reviewer

@rheh rheh rheh approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Bug FrameworkBundle Routing Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@HypeMC @nicolas-grekas @rheh @carsonbot